[WIP] Conditions Hierarchy by vzotova · Pull Request #444 · nucypher/nucypher-contracts

vzotova · 2025-11-12T19:22:18Z

Type of PR:

Bugfix
Feature
Documentation
Other

Required reviews:

1
2
3

What this does:

High-level idea of the changes introduced in this PR.
List relevant API changes (if any), as well as related PRs and issues.

Issues fixed/closed:

Fixes #...

Why it's needed:

Explain how this PR fits in the greater context of the NuCypher Network.
E.g., if this PR address a nucypher/productdev issue, let reviewers know!

Notes for reviewers:

What should reviewers focus on?
Is there a particular commit/function/section of your PR that requires more attention from reviewers?

… SigningCoordinator contract.

…or cohort participant.

…note this is specific to the same chain as the signing coordinator.

… definition.

…s are not allowed.

…iator role.

…testnet.

…being invalid - need to improve upgrade process through reinitializers next time.

…e on Ethereum with SigningCoordinatorChild contracts on L2s.

…olia <-> Base Sepolia.

…dispatcher and registration of bridges / SigningCoordinatorChild contract specific to chain.

…ning coordinator dispatcher, and the creation of the multisig on the same chain. (next will be for cross-chain).

…on either side of the bridge.

… interfaces.

…cohort on other chains via bridges. Bridge logic is abstracted away in the dispatcher contract which was updated for L1->L2 sender/receiver interfaces. Update signing coordinator tests accordingly.

Add test for cross-chain deployment. (Need to figure out why multisig addresses end up being different).

…address when registering and the chain is the current chain. Add tests for SigningCoordinatorDispatcher.

Revamped `lynx` contract deployments for signing infrastructure

`ThresholdSigningMultisig` tests

More testing of Signing Contracts

Copilot

Pull request overview

This is a Work-In-Progress (WIP) PR that introduces a comprehensive signing infrastructure called "Conditions Hierarchy" for the TACo network. The PR adds support for threshold signing multisig wallets that can be deployed across multiple chains, enabling cohort-based signature collection with cross-chain capabilities.

Key Changes

New Signing Coordinator Infrastructure: Introduces SigningCoordinator, SigningCoordinatorChild, and SigningCoordinatorDispatcher contracts to manage signing cohorts with cross-chain deployment support
Threshold Signing Multisig: Implements ERC-1271 compliant threshold multisig wallet with clone factory pattern for efficient deployment
Cross-Chain Bridge Support: Adds Optimism-based L1/L2 bridge contracts (OpL1Sender, OpL2Receiver) for cross-chain communication
Testing & Scripts: Comprehensive test coverage for new contracts and deployment/management scripts for lynx testnet

Reviewed changes

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
contracts/contracts/coordination/SigningCoordinator.sol	Main coordinator contract for managing signing cohorts with multi-chain support
contracts/contracts/coordination/ThresholdSigningMultisig.sol	ERC-1271 threshold multisig implementation with signer management
contracts/contracts/coordination/ThresholdSigningMultisigCloneFactory.sol	Factory for deterministic multisig clone deployment
contracts/contracts/coordination/SigningCoordinatorChild.sol	Child contract for deploying multisigs on target chains
contracts/contracts/coordination/SigningCoordinatorDispatcher.sol	Dispatcher for routing calls to appropriate chains
contracts/contracts/coordination/OpL1Sender.sol	L1 sender for Optimism bridge communication
contracts/contracts/coordination/OpL2Receiver.sol	L2 receiver for processing bridge messages
contracts/xchain/PolygonChild.sol	Added payable modifier to fallback function
tests/test_threshold_signing_multisig.py	Comprehensive tests for multisig functionality
tests/test_signing_coordinator.py	Tests for signing coordinator and cross-chain operations
scripts/form_signing_cohort.py	Script to initiate new signing cohorts
scripts/set_signing_cohort_conditions.py	Script to set conditions for cohorts
scripts/signing_cohort_additional_chain.py	Script to deploy cohort to additional chains
scripts/verify.py	Enhanced to support multiple contract verification
scripts/lynx/*.py	Deployment scripts for lynx testnet infrastructure
src/index.ts	Added SigningCoordinator to contract registry
test/registry.spec.ts	Updated tests for SigningCoordinator registry
requirements.txt	Updated Python dependencies
ape-config.yaml	Increased test account count to 70

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

derekpierre · 2025-12-01T19:57:52Z


        require(
-            signingCohort.authority == msg.sender || serverAdmin.active,
+            signingCohort.authority == msg.sender || server.activeServerAdmins[msg.sender],


Does this mean that the cohort authority can override a server admin for setting the serverId-specific condition? If so, I don't think we want to give the cohort authority that power.

Only the server admin can set the serverId-specific condition. (cc @arjunhassard )

But cohort admin can set itself to server admin anyway, right?

You're right that technically they can take that route to set a serverid-specific condition.

Typically the cohort admin and server admins should be separate. They may be the same in Collab.Land's Discord server, but shouldn't be for other Discord servers.

Removed privilege for cohort admin

derekpierre · 2025-12-01T20:08:07Z

        emit SigningCohortConditionsSet(cohortId, msg.sender, chainId, conditions);
    }

+    function getUnsignedTransactionHash(


"If" we go this route (of getting conditions signed by the cohort), would a similar function to getSigningCohortDataHash(...) (which we use for the ritual) be simpler? I'm particularly worried about the use of nonce and that multisig function. wdyt?

yeah, it can be without nonce similar to getSigningCohortDataHash, but it will open ability to execute same tx twice which in that case should not be big deal

Removed nonce and simplified in general

cygnusv

some very early comments

cygnusv · 2025-12-03T16:15:44Z

        uint256[20] gap;
    }

+    struct Server {


I think we should find a more generic term for Server, which is too specific to a particular use case. What about something like Domain?

I like Domain

cygnusv · 2025-12-03T17:21:43Z


        require(
-            signingCohort.authority == msg.sender || serverAdmin.active,
+            signingCohort.authority == msg.sender || server.activeServerAdmins[msg.sender],


But cohort admin can set itself to server admin anyway, right?

cygnusv · 2025-12-03T17:22:08Z

+    ) external {
+        SigningCohort storage signingCohort = signingCohorts[cohortId];
+        conditionsCheck(signingCohort, chainId);
+        require(serverId > 0, "Server id can't be zero");


why it can't be zero?

some optimization for getSigningCohortConditions

derekpierre · 2026-02-23T17:00:29Z

Blocked by https://github.com/nucypher/sprints/issues/298

derekpierre and others added 30 commits November 14, 2025 11:17

Initial musing about creation of signing cohort, utilizing a separate…

ffcd98d

… SigningCoordinator contract.

Minor rename.

5c394bd

Store SigningCohortParticipants as a list instead of a mapping.

b61c1cc

Add getSigner() function and fix bug where signature was not stored f…

c28b8f7

…or cohort participant.

Use eip191 signing for signing cohort formation.

207e960

Add the ability to deployer a multisig as part of cohort formation - …

23fd883

…note this is specific to the same chain as the signing coordinator.

Be sure to use operator addresses and not provider address for signers.

0570525

Adjust logic for caching signatures.

64a4578

Signing cohort id is a uint32 (for now), so use it for cohort mapping…

0fae651

… definition.

Ensure that signatures for cohort multisig are unique and that repeat…

f1afe8a

…s are not allowed.

Obtain data to sign for ritual from contract.

718a12c

Limit initiation of signing cohort rituals to only accounts with init…

546021f

…iator role.

Deploy signing infrastructure contracts to polygon amoy for the lynx …

918ef37

…testnet.

introduces condition storage to the signing cohort struct

25d3135

basic testing for onchain conditions

9ad0d30

signing corrdinator upgrade deployment scripts

4254cf3

Test cleanup.

b3137f1

Redeploy SigningCoordinator after trying to upgrade but then storage …

20df5b2

…being invalid - need to improve upgrade process through reinitializers next time.

Fix linting for PolygonChile.

602bca1

Initial musing about canonical SigningCoordinator contract that can b…

e6a1927

…e on Ethereum with SigningCoordinatorChild contracts on L2s.

Initial musing regarding Optimism-based bridged contracts eg. Eth Sep…

15dc5db

…olia <-> Base Sepolia.

Ensure that ape chain id is properly maintained for tests.

2908cc0

Some initial code for managing cohorts across different chains via a …

d2d20d1

…dispatcher and registration of bridges / SigningCoordinatorChild contract specific to chain.

Update tests to account for set up of single signing coordinator, sig…

ddd4b54

…ning coordinator dispatcher, and the creation of the multisig on the same chain. (next will be for cross-chain).

Rename sender/receiver contracts.

0303b13

Establish abstracted interfaces for L1->L2 sender/receiver contracts …

3f557d9

…on either side of the bridge.

Update implementations of sender/receiver interfaces to match updated…

7941cef

… interfaces.

Update SigningCoordinator to be able to handle deployment of signing …

3d0b324

…cohort on other chains via bridges. Bridge logic is abstracted away in the dispatcher contract which was updated for L1->L2 sender/receiver interfaces. Update signing coordinator tests accordingly.

Update code for deploying cohort multisigs on other chains.

589daf9

Add test for cross-chain deployment. (Need to figure out why multisig addresses end up being different).

Code cleanup for internal method on SigningCoordinator.

e701331

derekpierre added 6 commits November 14, 2025 11:19

Update SigningCoordinatorDispatcher to ensure l1 sender address is 0-…

39722b2

…address when registering and the chain is the current chain. Add tests for SigningCoordinatorDispatcher.

Add tests for threshold signing multisig contract.

3285d85

Merge pull request nucypher#441 from derekpierre/new-signing-coordinator

5804859

Revamped `lynx` contract deployments for signing infrastructure

Add tests for SigningCoordinatorChild.

98c3f91

Merge pull request nucypher#442 from derekpierre/multisig-testing

7588451

`ThresholdSigningMultisig` tests

Merge pull request nucypher#443 from derekpierre/more-testing

406295c

More testing of Signing Contracts

derekpierre force-pushed the signing branch from 61534e4 to 406295c Compare November 14, 2025 16:20

derekpierre requested review from Copilot, cygnusv and derekpierre and removed request for Copilot and derekpierre November 25, 2025 15:43

Copilot started reviewing on behalf of derekpierre November 25, 2025 15:43 View session

vzotova added 2 commits November 25, 2025 10:44

Draft for conditions hierarchy

48273ab

Adds server id as a parameter

cba3b3a

vzotova force-pushed the hierarchy branch from a5b8c10 to cba3b3a Compare November 25, 2025 15:45

Copilot finished reviewing on behalf of derekpierre November 25, 2025 15:47

Copilot AI reviewed Nov 25, 2025

View reviewed changes

Copilot finished reviewing on behalf of derekpierre November 25, 2025 15:48

derekpierre requested a review from arjunhassard November 25, 2025 15:51

derekpierre assigned vzotova Nov 25, 2025

Allows to set server conditions only if they are signed by cohort

5a3f9a9

derekpierre reviewed Dec 1, 2025

View reviewed changes

cygnusv reviewed Dec 3, 2025

View reviewed changes

Renames server -> domain. Simplifies hash

84c0de8

derekpierre force-pushed the signing branch from 9214030 to 219ca81 Compare January 27, 2026 20:19

Uh oh!

Conversation

vzotova commented Nov 12, 2025 • edited by derekpierre Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes

Reviewed changes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cygnusv left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

derekpierre commented Feb 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

vzotova commented Nov 12, 2025 •

edited by derekpierre

Loading